Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DellEMC] Dell Platform Modules Debian Build Error Fix #4108

Merged
merged 3 commits into from
Feb 7, 2020

Conversation

santhosh-kt
Copy link
Contributor

@santhosh-kt santhosh-kt commented Feb 4, 2020

- What I did

  • Fix for Azure/sonic-buildimage#4095
  • Exit status from failed make command(action) didnt reached parent target because the make command is inside the "for" loop.
  • Only the exit status of the last command in the last iteration of the for loop is read by parent target.
  • This is the reason why dpkg-buildpackage ignored the make error.
  • Fixed the issue with help of "set -e".

- How I did it
On branch s6000-build-error
Changes to be committed:
(use "git reset HEAD ..." to unstage)

    modified:   platform/broadcom/sonic-platform-modules-dell/s6000/modules/dell_s6000_platform.c

- How to verify it
Attached UT Logs:
Before Fix - platform-modules-z9100_1.1_amd64.deb-without-fix.log.txt

After Fix - platform-modules-z9100_1.1_amd64.deb-with-fix.log.txt
After Fix and platfrom debian completed with no issues log - platform-modules-z9100_1.1_amd64.deb-no-error.log.txt

- Description for the changelog

[DellEMC] Dell Platform Modules Debian Build Error Fix

- A picture of a cute animal (not mandatory but encouraged)

@santhosh-kt
Copy link
Contributor Author

Will check and update the build failure message.

@santhosh-kt
Copy link
Contributor Author

Note: Upon build failure on vendor specific files , until the failure is addressed, further builds will be stopped.

@@ -37,7 +38,8 @@ override_dh_auto_build:
fi; \
echo "making man page alias $$mod -> $$mod APIs";\
make -C $(KERNEL_SRC)/build M=$(MOD_SRC_DIR)/$${mod}/modules; \
done)
done); \
set +e;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about failure in the install phase?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@padmanarayana
Copy link
Contributor

Fixes #4095

@lguohan lguohan merged commit 57d4c84 into sonic-net:master Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants