Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sonic-platform-modules-dell s6000 build failure does not cause job build failure #4095

Closed
lguohan opened this issue Feb 3, 2020 · 3 comments
Closed

sonic-platform-modules-dell s6000 build failure does not cause job build failure #4095

lguohan opened this issue Feb 3, 2020 · 3 comments

Comments

@lguohan
Copy link
Collaborator

lguohan commented Feb 3, 2020

Description

Steps to reproduce the issue:

  1. check the buid log

Describe the results you received:
s6000 build failure should cause the dpkg-buildpackage -uc -ub to fail. However such failure is ignored.

Describe the results you expected:
Please improve the build script not to ignore any error.

Additional information you deem important (e.g. issue happens only occasionally):

**Output of `show version`:**

```
(paste your output here)
```

**Attach debug file `sudo generate_dump`:**

```
(paste your output here)
```
@lguohan
Copy link
Collaborator Author

lguohan commented Feb 3, 2020

platform-modules-z9100_1.1_amd64.deb.log

@santhosh-kt santhosh-kt mentioned this issue Feb 4, 2020
Merged
@xinliu-seattle
Copy link
Contributor

@padmanarayana to make sure the fix is in.

@padmanarayana
Copy link
Contributor

@santhosh-kt raised #4108

lguohan pushed a commit that referenced this issue Feb 7, 2020
@santhosh-kt
[DellEMC] Dell Platform Modules Debian Build Error Fix (#4108)
57d4c84 
- Fix for #4095
- Exit status from failed make command(action) didnt reached parent target because the make command is inside the "for" loop.
- Only the exit status of the last command in the last iteration of the for loop is read by parent target.
- This is the reason why dpkg-buildpackage ignored the make error.
- Fixed the issue with help of "set -e".
@lguohan lguohan closed this as completed Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lguohan @xinliu-seattle @padmanarayana