[action] [PR:20964] [Mellanox] [SFP API] Add support to the get_error_description function for when CMIS cable host management is enabled. (#20964) #21215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n for when CMIS cable host management is enabled. (sonic-net#20964) - Why I did it get_error_description is not supported when CMIS cable host mgmt. enabled, now enable this function and use the community common implementation. - How I did it When CMIS cable host mgmt. enabled, call the common platform API. Keep using original implementation in FW control mode. - How to verify it Test this API on different platforms in different modes. Run SFP related sonic-mgmt test cases Signed-off-by: Kebo Liu <kebol@nvidia.com>
|
Original PR: #20964 |
12 tasks
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
get_error_description is not supported when CMIS cable host mgmt. enabled, now enable this function and use the community common implementation.
How I did it
When CMIS cable host mgmt. enabled, call the common platform API. Keep using original implementation in FW control mode.
How to verify it
Test this API on different platforms in different modes.
Run SFP related sonic-mgmt test cases
Signed-off-by: Kebo Liu kebol@nvidia.com