[Mellanox] [SFP API] Add support to the get_error_description function for when CMIS cable host management is enabled. #20964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kebo Liu <kebol@nvidia.com>
Junchao-Mellanox
approved these changes
Nov 29, 2024
mihirpat1
approved these changes
Dec 2, 2024
liat-grozovik
approved these changes
Dec 3, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Dec 18, 2024
…n for when CMIS cable host management is enabled. (sonic-net#20964) - Why I did it get_error_description is not supported when CMIS cable host mgmt. enabled, now enable this function and use the community common implementation. - How I did it When CMIS cable host mgmt. enabled, call the common platform API. Keep using original implementation in FW control mode. - How to verify it Test this API on different platforms in different modes. Run SFP related sonic-mgmt test cases Signed-off-by: Kebo Liu <kebol@nvidia.com>
|
Cherry-pick PR to 202405: #21215 |
mssonicbld
pushed a commit
that referenced
this pull request
Dec 18, 2024
…n for when CMIS cable host management is enabled. (#20964) - Why I did it get_error_description is not supported when CMIS cable host mgmt. enabled, now enable this function and use the community common implementation. - How I did it When CMIS cable host mgmt. enabled, call the common platform API. Keep using original implementation in FW control mode. - How to verify it Test this API on different platforms in different modes. Run SFP related sonic-mgmt test cases Signed-off-by: Kebo Liu <kebol@nvidia.com>
JibinBao
added a commit
to JibinBao/sonic-mgmt
that referenced
this pull request
Jan 17, 2025
…nic-buildimage#20964 When software control is enabled, the port error status is as follows: 1. For active module, the expected state is OK 2. For cmis passive module, the expected state is ModuleLowPwr 3. For non cmis passive module, the expected state is 'Not supported' when software control is disabled, the port error status keep the original behaviour
11 tasks
JibinBao
added a commit
to JibinBao/sonic-mgmt
that referenced
this pull request
Jan 20, 2025
…nic-buildimage#20964 When software control is enabled, the port error status is as follows: 1. For active module, the expected state is OK 2. For cmis passive module, the expected state is ModuleLowPwr 3. For non cmis passive module, the expected state is 'Not supported' when software control is disabled, the port error status keep the original behaviour
VladimirKuk
pushed a commit
to Marvell-switching/sonic-buildimage
that referenced
this pull request
Jan 21, 2025
…n for when CMIS cable host management is enabled. (sonic-net#20964) - Why I did it get_error_description is not supported when CMIS cable host mgmt. enabled, now enable this function and use the community common implementation. - How I did it When CMIS cable host mgmt. enabled, call the common platform API. Keep using original implementation in FW control mode. - How to verify it Test this API on different platforms in different modes. Run SFP related sonic-mgmt test cases Signed-off-by: Kebo Liu <kebol@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
get_error_description is not supported when CMIS cable host mgmt. enabled, now enable this function and use the community common implementation.
Work item tracking
How I did it
When CMIS cable host mgmt. enabled, call the common platform API. Keep using original implementation in FW control mode.
How to verify it
Test this API on different platforms in different modes.
Run SFP related sonic-mgmt test cases
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)