[chassis][202405]: Remove default hash-offset for chassis-packet #19745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: anamehra <anamehra@cisco.com>
abdosi
approved these changes
Aug 1, 2024
|
/azp run ms_checker |
|
No pipelines are associated with this pull request. |
|
/azpw ms_conflict -f |
1 similar comment
|
/azpw ms_conflict -f |
|
/azp run Azure.sonic-buildimage |
|
Commenter does not have sufficient privileges for PR 19745 in repo sonic-net/sonic-buildimage |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
wangxin
approved these changes
Sep 4, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Sep 4, 2024
Why I did it Fixes sonic-net#19746 switch.json in swss docker sets the default hash offset to 0 for chassis-packet. The change was recently introduced via sonic-net#18912 which was supposed to be only for T0/T1. On chassis-packet, each asics needs to set an unique hash offset to set an unique offset for load balancing algorithm. The new change overwrites platform setting and resets the hash-offset to 0 on all asics. This breaks the ecmp load balancing algorithm on chassis-packet. How I did it Remove the default hash-offset setting for chassis-packet. This setting is provided by platform based on platform specific rules. How to verify it Run sonic-mgmt fib/test_fib.py Signed-off-by: anamehra <anamehra@cisco.com>
|
Cherry-pick PR to 202405: #20126 |
mssonicbld
pushed a commit
that referenced
this pull request
Sep 5, 2024
Why I did it Fixes #19746 switch.json in swss docker sets the default hash offset to 0 for chassis-packet. The change was recently introduced via #18912 which was supposed to be only for T0/T1. On chassis-packet, each asics needs to set an unique hash offset to set an unique offset for load balancing algorithm. The new change overwrites platform setting and resets the hash-offset to 0 on all asics. This breaks the ecmp load balancing algorithm on chassis-packet. How I did it Remove the default hash-offset setting for chassis-packet. This setting is provided by platform based on platform specific rules. How to verify it Run sonic-mgmt fib/test_fib.py Signed-off-by: anamehra <anamehra@cisco.com>
vvolam
pushed a commit
to vvolam/sonic-buildimage
that referenced
this pull request
Sep 12, 2024
Why I did it Fixes sonic-net#19746 switch.json in swss docker sets the default hash offset to 0 for chassis-packet. The change was recently introduced via sonic-net#18912 which was supposed to be only for T0/T1. On chassis-packet, each asics needs to set an unique hash offset to set an unique offset for load balancing algorithm. The new change overwrites platform setting and resets the hash-offset to 0 on all asics. This breaks the ecmp load balancing algorithm on chassis-packet. How I did it Remove the default hash-offset setting for chassis-packet. This setting is provided by platform based on platform specific rules. How to verify it Run sonic-mgmt fib/test_fib.py Signed-off-by: anamehra <anamehra@cisco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: anamehra@cisco.com
Why I did it
Fixes #19746
switch.json in swss docker sets the default hash offset to 0 for chassis-packet. The change was recently introduced via #18912 which was supposed to be only for T0/T1. On chassis-packet, each asics needs to set an unique hash offset to set an unique offset for load balancing algorithm. The new change overwrites platform setting and resets the hash-offset to 0 on all asics. This breaks the ecmp load balancing algorithm on chassis-packet.
Work item tracking
How I did it
Remove the default hash-offset setting for chassis-packet. This setting is provided by platform based on platform specific rules.
How to verify it
Run sonic-mgmt fib/test_fib.py
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)