Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chassis][202405]: Default hash-offset 0 causes ecmp load balancing failure on chassis-packet #19746

Closed
anamehra opened this issue Jul 31, 2024 · 2 comments · Fixed by #19745
Closed
Assignees
Labels
Cisco Triaged this issue has been triaged

Comments

@anamehra
Copy link
Contributor

Description

switch.json in swss docker sets the default hash offset to 0 for chassis-packet. The change was recently introduced via #18912 which was supposed to be only for T0/T1. On chassis-packet, each asics needs to set an unique hash offset to set an unique offset for load balancing algorithm. The new change overwrites platform setting and resets the hash-offset to 0 on all asics. This breaks the ecmp load balancing algorithm on chassis-packet.

Steps to reproduce the issue:

Describe the results you received:

Describe the results you expected:

Output of show version:

(paste your output here)

Output of show techsupport:

(paste your output here or download and attach the file here )

Additional information you deem important (e.g. issue happens only occasionally):

@judyjoseph
Copy link
Contributor

@kperumalbfn f.y.i trying to not set the default for chassis-packet

@judyjoseph judyjoseph added Triaged this issue has been triaged Cisco labels Jul 31, 2024
@kperumalbfn
Copy link
Contributor

@anamehra For multi-asic and chassis platform, could you add the changes to sonic-swss code to apply hash_offset value using SAI attribute instead of setting inside platform code? I think that will be better instead of changes mentioned in PR - #19745

@wangxin wangxin closed this as completed in f0979dd Sep 4, 2024
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this issue Sep 4, 2024
Why I did it
Fixes sonic-net#19746

switch.json in swss docker sets the default hash offset to 0 for chassis-packet. The change was recently introduced via sonic-net#18912 which was supposed to be only for T0/T1. On chassis-packet, each asics needs to set an unique hash offset to set an unique offset for load balancing algorithm. The new change overwrites platform setting and resets the hash-offset to 0 on all asics. This breaks the ecmp load balancing algorithm on chassis-packet.

How I did it
Remove the default hash-offset setting for chassis-packet. This setting is provided by platform based on platform specific rules.

How to verify it
Run sonic-mgmt fib/test_fib.py

Signed-off-by: anamehra <anamehra@cisco.com>
mssonicbld pushed a commit that referenced this issue Sep 5, 2024
Why I did it
Fixes #19746

switch.json in swss docker sets the default hash offset to 0 for chassis-packet. The change was recently introduced via #18912 which was supposed to be only for T0/T1. On chassis-packet, each asics needs to set an unique hash offset to set an unique offset for load balancing algorithm. The new change overwrites platform setting and resets the hash-offset to 0 on all asics. This breaks the ecmp load balancing algorithm on chassis-packet.

How I did it
Remove the default hash-offset setting for chassis-packet. This setting is provided by platform based on platform specific rules.

How to verify it
Run sonic-mgmt fib/test_fib.py

Signed-off-by: anamehra <anamehra@cisco.com>
vvolam pushed a commit to vvolam/sonic-buildimage that referenced this issue Sep 12, 2024
Why I did it
Fixes sonic-net#19746

switch.json in swss docker sets the default hash offset to 0 for chassis-packet. The change was recently introduced via sonic-net#18912 which was supposed to be only for T0/T1. On chassis-packet, each asics needs to set an unique hash offset to set an unique offset for load balancing algorithm. The new change overwrites platform setting and resets the hash-offset to 0 on all asics. This breaks the ecmp load balancing algorithm on chassis-packet.

How I did it
Remove the default hash-offset setting for chassis-packet. This setting is provided by platform based on platform specific rules.

How to verify it
Run sonic-mgmt fib/test_fib.py

Signed-off-by: anamehra <anamehra@cisco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cisco Triaged this issue has been triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants