-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Conversation
9e85e0d
to
296f20b
Compare
2871b0a
to
e8f914b
Compare
07e1561
to
a8e18ed
Compare
Thanks for doing this! I took a crack at this a few months ago, but ran into a CI issue that held things up before the PR fell off my radar. Nice to have a single point to change on all these deps, definitely simplifies operations that need to be done manually / shrinks diffs from running scripts. A question from the old review that came up that I'll post here in case anyone else might have the same question:
The answer is yes, and I confirmed it by running the following and inspecting the generated Cargo.toml file.
|
Do you plan on backporting this to v1.14? I'm running some tests (all good so far) but my attempt to cherry pick to v1.14 ran into a bunch of trivial conflicts. Just wondering if I should take the time to test on v1.14. |
No 1.14 backport please, too much churn for a stable branch |
downstream project failed due to https://www.github.com/hyperium/hyper/issues/3045 |
Seems reasonable to me; think it makes sense to do those bumps in separate PR's like the other dependency bump PR's I see you've opened recently |
4f3fed1
to
5a20d5e
Compare
9e3abe9
to
5397dd5
Compare
5397dd5
to
53827db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a large diff so not going to pretend I went through every line. Instead, the checks I performed:
- Ran
cargo tree
on current tip of master and the PR branch and compared output; there was no difference - When I took a crack at this a while back, I tested a concern Michael had about the correct version getting populated in individual crates. I had tested that and tested again with no issue.
- I tested by running
cargo publish --dry-run --package solana-logger
and inspecting/target/package/solana-logger-1.15.0/Cargo.toml
- I tested by running
seems sufficiently rigorous to me! |
This reverts commit a67d239.
|
workspace.package
workspace.dependencies
btw, I merge some dependencies's version. if A use
foo = "1"
and B usefoo = "1.10.1"
, I move foo = "1.10.1" to workspace and both A and B inherit it.there are some dependencies's version are different. I will make other PRs to union them.
scripts
version = { workspace = true }