solana-accounts-tool crate

[yhchiang-sol]

Summary of Changes

This PR creates an empty crate for solana-acounts-tool

https://crates.io/crates/solana-accounts-tool

[steviez]

Will port existing account-related commands from ledger-tool to accounts-tool
in separate PRs.

I think the creation of a second tool (the crate this PR is adding) is a good way to separate out logic that operate on separate pieces (ie blockstore vs. accountsDB). However, now that we have the PR and thinking more practically about how we'd do all this, one thing that isn't clear to me is how we should handle the "gray" area with these tools:

1. Something like solana-ledger-tool bounds is ledger-tool only
2. Something like scanning a specific AppendVec is accounts-tool only
3. Something like printing all the accounts could fall in both
   • Someone might have an existing accounts directory that they want to do stuff with
   • Someone might want to unpack a snapshot and do some stuff on the contents
   • Someone might want to unpack a snapshot + replay slots + then do some stuff on the end state

If we rip accounts subcommand out of ledger-tool, then we remove the ability to do the third bulleted item, which would make someone have to use both tools (ie create a snapshot with ledger-tool and then accounts-tool to interact with it) which isn't a great workflow. On the flip-side, we don't necessarily want a ton of duplication between the two tools.

Although maybe code duplication isn't as big of a concern as I'm making it out to be if the tools have different starting points in terms of what they operate on:

• ledger-tool unpacks a snapshot + has access to a Bank / AccountsDb and all the associations that come with that
• accounts-tool works with an existing accounts directory, and works with AppendVecs directly instead of through the higher level constructs in previous bullet

[t-nelson]

If we rip accounts subcommand out of ledger-tool, then we remove the ability to do the third bulleted item

could use solana-ledger-tool create-snapshot as the marshaling interface?

[yhchiang-sol]

Cleaned up dependencies and have the main function empty.

[yhchiang-sol]

Although maybe code duplication isn't as big of a concern as I'm making it out to be if the tools have different starting points in terms of what they operate on:

• ledger-tool unpacks a snapshot + has access to a Bank / AccountsDb and all the associations that come with that
• accounts-tool works with an existing accounts directory, and works with AppendVecs directly instead of through the higher level constructs in previous bullet

Since ledger-tool is already viewed as the "all-in-one" tool, I think we can have accounts-tool accountable for all accounts-only operations, while everything else sits inside ledger-tool.

With the above roles, we can still keep ledger-tool account subcommand which offers operations that touch both ledger and accounts-db.

[steviez]

Nice, thanks for ripping all of the extras out; a little more work but should avoid bloat.

And can confirm that I see https://crates.io/crates/solana-accounts-tool here so I think we're good on that front! That being said, I've never published a crate before, so wouldn't mind explicit confirmation from someone who has. Tyera resolved the issue about publishing the crate, but don't want to infer too far

Pull request has been modified.

[yhchiang-sol]

Abandoning this PR as we decided to have a single tool (i.e., ledger-tool) that includes all the commands.