Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect provider list notified when scanning file changes. #219

Merged
merged 4 commits into from
Jul 7, 2018

Conversation

huangyunbin
Copy link
Contributor

@codecov-io
Copy link

codecov-io commented Jul 4, 2018

Codecov Report

Merging #219 into 5.4 will increase coverage by 0.48%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##                5.4    #219      +/-   ##
===========================================
+ Coverage     70.92%   71.4%   +0.48%     
- Complexity      957     961       +4     
===========================================
  Files           341     341              
  Lines         13651   14213     +562     
  Branches       2208    2286      +78     
===========================================
+ Hits           9682   10149     +467     
- Misses         2789    2874      +85     
- Partials       1180    1190      +10
Impacted Files Coverage Δ Complexity Δ
.../alipay/sofa/rpc/registry/local/LocalRegistry.java 66.26% <100%> (+8.94%) 29 <0> (+3) ⬆️
...java/com/alipay/sofa/rpc/context/AsyncRuntime.java 53.84% <0%> (-9.8%) 0% <0%> (ø)
...alipay/sofa/rpc/api/future/SofaResponseFuture.java 55.17% <0%> (-6.37%) 5% <0%> (ø)
...pay/sofa/rpc/transport/http/SslContextBuilder.java 18.75% <0%> (-6.25%) 2% <0%> (ø)
...fa/rpc/bootstrap/dubbo/DubboProviderBootstrap.java 60.44% <0%> (-6.22%) 0% <0%> (ø)
...ay/sofa/rpc/protocol/telnet/HelpTelnetHandler.java 82.35% <0%> (-5.15%) 0% <0%> (ø)
...va/com/alipay/sofa/rpc/client/FailoverCluster.java 74.28% <0%> (-4.29%) 0% <0%> (ø)
...va/com/alipay/sofa/rpc/client/FailFastCluster.java 75% <0%> (-2.78%) 0% <0%> (ø)
.../main/java/com/alipay/sofa/rpc/tracer/Tracers.java 39.74% <0%> (-2.57%) 0% <0%> (ø)
...n/java/com/alipay/sofa/rpc/ext/ExtensionClass.java 77.77% <0%> (-2.23%) 0% <0%> (ø)
... and 123 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f94a24...485f718. Read the comment docs.

@ujjboy
Copy link
Member

ujjboy commented Jul 4, 2018

Thanks for PR. I will change merge base from master to branch 5.4.

Could you add test case for this ? For check com.alipay.sofa.rpc.registry.local.LocalRegistry#notifyConsumer, may by you need change the access level of this method from private to default.

@ujjboy ujjboy added the bug Something isn't working label Jul 4, 2018
@ujjboy ujjboy added this to the 5.4.3 milestone Jul 4, 2018
@ujjboy ujjboy changed the base branch from master to 5.4 July 4, 2018 14:45
@huangyunbin
Copy link
Contributor Author

i have add test for add notifyConsumer

@ujjboy ujjboy changed the title #218 fix LocalRegistry notifyConsumer bug Incorrectly provider list notified when scanning file change. Jul 7, 2018
@ujjboy ujjboy changed the title Incorrectly provider list notified when scanning file change. Incorrectly provider list notified when scanning file changes. Jul 7, 2018
@ujjboy ujjboy merged commit 4b4b1da into sofastack:5.4 Jul 7, 2018
@ujjboy ujjboy changed the title Incorrectly provider list notified when scanning file changes. Incorrect provider list notified when scanning file changes. Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants