Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LocalRegistry notifyConsumer has a bug #218

Closed
huangyunbin opened this issue Jul 4, 2018 · 1 comment
Closed

LocalRegistry notifyConsumer has a bug #218

huangyunbin opened this issue Jul 4, 2018 · 1 comment
Milestone
5.4.3

Comments

@huangyunbin
Copy link
Contributor

huangyunbin commented Jul 4, 2018 •
edited
Loading 

 ProviderGroup innew = differentValue.rightValue();

shoule be

ProviderGroup innew = differentValue.leftValue();

if you start LocalBoltClientMain first,and then start LocalBoltServerMain, you can find client not find server,the reason is this bug
huangyunbin pushed a commit to huangyunbin/sofa-rpc that referenced this issue Jul 4, 2018
sofastack#218 fix LocalRegistry notifyConsumer bug
a8ae530
@huangyunbin huangyunbin mentioned this issue Jul 4, 2018
Merged
@leizhiyuan
Copy link
Contributor

@huangyunbin Thanks! please pr your changes to branch 5.4, we will merge it.

@leizhiyuan leizhiyuan added this to the 5.4.3 milestone Jul 6, 2018
huangyunbin pushed a commit to huangyunbin/sofa-rpc that referenced this issue Jul 7, 2018
sofastack#218 add notifyConsumerTest
dba9878
huangyunbin pushed a commit to huangyunbin/sofa-rpc that referenced this issue Jul 7, 2018
sofastack#218 format
485f718
ujjboy pushed a commit that referenced this issue Jul 7, 2018
@huangyunbin @ujjboy
Incorrectly provider list notified when scanning file changes.
4b4b1da 
Fix #218
@ujjboy ujjboy closed this as completed Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.4.3
Development

No branches or pull requests
3 participants
@huangyunbin @ujjboy @leizhiyuan