Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/time consuming refinement #1066

Merged
merged 17 commits into from
Oct 28, 2021

Conversation

EvenLjj
Copy link
Collaborator

@EvenLjj EvenLjj commented Aug 12, 2021

time consuming refinement

Copy link
Member

@JervyShi JervyShi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #1066 (4de2a9d) into master (cd29f08) will increase coverage by 0.12%.
The diff coverage is 96.62%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1066      +/-   ##
============================================
+ Coverage     69.05%   69.18%   +0.12%     
+ Complexity      830      829       -1     
============================================
  Files           409      410       +1     
  Lines         17721    17860     +139     
  Branches       2749     2762      +13     
============================================
+ Hits          12238    12357     +119     
- Misses         4066     4082      +16     
- Partials       1417     1421       +4     
Impacted Files Coverage Δ
...om/alipay/sofa/rpc/event/SofaTracerSubscriber.java 93.75% <ø> (ø)
...fa/rpc/tracer/sofatracer/log/tags/RpcSpanTags.java 0.00% <ø> (ø)
...ipay/sofa/rpc/server/bolt/BoltServerProcessor.java 64.86% <84.61%> (+1.62%) ⬆️
...y/sofa/rpc/transport/bolt/BoltClientTransport.java 83.22% <85.71%> (+0.11%) ⬆️
...m/alipay/sofa/rpc/server/ProviderProxyInvoker.java 94.44% <91.66%> (-5.56%) ⬇️
...va/com/alipay/sofa/rpc/client/AbstractCluster.java 69.37% <94.44%> (+0.79%) ⬆️
.../java/com/alipay/sofa/rpc/common/RpcConstants.java 100.00% <100.00%> (ø)
...alipay/sofa/rpc/event/ClientAsyncReceiveEvent.java 100.00% <100.00%> (ø)
.../alipay/sofa/rpc/event/ClientStartInvokeEvent.java 100.00% <100.00%> (ø)
.../alipay/sofa/rpc/event/ClientSyncReceiveEvent.java 84.61% <100.00%> (+1.28%) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd29f08...4de2a9d. Read the comment docs.

@EvenLjj EvenLjj added this to the 5.8.0 milestone Sep 13, 2021
Copy link
Contributor

@OrezzerO OrezzerO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EvenLjj EvenLjj merged commit 9b9a478 into sofastack:master Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants