Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom header #1050

Merged
merged 3 commits into from
Jun 29, 2021
Merged

Support custom header #1050

merged 3 commits into from
Jun 29, 2021

Conversation

OrezzerO
Copy link
Contributor

Motivation:

Add an api to add custom headers

@sofastack-bot sofastack-bot bot added cla:yes CLA is ok size/L labels Jun 23, 2021
@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #1050 (cb10a54) into master (03abf33) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1050      +/-   ##
============================================
- Coverage     68.84%   68.69%   -0.15%     
+ Complexity      820      817       -3     
============================================
  Files           407      408       +1     
  Lines         17619    17634      +15     
  Branches       2728     2729       +1     
============================================
- Hits          12130    12114      -16     
- Misses         4085     4113      +28     
- Partials       1404     1407       +3     
Impacted Files Coverage Δ
...ay/sofa/rpc/filter/ConsumerCustomHeaderFilter.java 100.00% <100.00%> (ø)
...om/alipay/sofa/rpc/context/RpcInternalContext.java 83.76% <100.00%> (+0.87%) ⬆️
...java/com/alipay/sofa/rpc/module/LookoutModule.java 52.38% <0.00%> (-33.34%) ⬇️
...m/alipay/sofa/rpc/module/FaultToleranceModule.java 63.63% <0.00%> (-31.82%) ⬇️
...ipay/sofa/rpc/server/bolt/BoltServerProcessor.java 63.23% <0.00%> (-5.15%) ⬇️
...a/com/alipay/sofa/rpc/event/LookoutSubscriber.java 85.22% <0.00%> (-2.28%) ⬇️
...a/com/alipay/sofa/rpc/common/utils/ClassUtils.java 78.23% <0.00%> (-2.05%) ⬇️
.../main/java/com/alipay/sofa/rpc/event/EventBus.java 70.58% <0.00%> (-1.97%) ⬇️
...ipay/sofa/rpc/tracer/sofatracer/RpcSofaTracer.java 88.13% <0.00%> (-0.90%) ⬇️
...lipay/sofa/rpc/message/AbstractResponseFuture.java 56.14% <0.00%> (-0.88%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03abf33...cb10a54. Read the comment docs.

Copy link
Collaborator

@EvenLjj EvenLjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EvenLjj EvenLjj merged commit 924d22d into sofastack:master Jun 29, 2021
EvenLjj added a commit to EvenLjj/sofa-rpc that referenced this pull request Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants