Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generation proto/field not nullable in response are not optional #284

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Generation proto/field not nullable in response are not optional #284

wants to merge 3 commits into from

Conversation

AMontagu
Copy link
Collaborator

@AMontagu AMontagu commented Apr 8, 2024

Fix #281

@AMontagu AMontagu requested a review from legau April 8, 2024 17:15
@AMontagu
Copy link
Collaborator Author

AMontagu commented Apr 9, 2024

PR blocked after discussion.
We figured out that having to pass request/response context to the proto field is not the wanted architecture.
We should do all the logic before calling ProtoMessage and ProtoField by using default generation plugin.
As this is a really big refacto this will be done but not anytime soon as the bug is not really important.

If someone really need this fix he can use this branch the time we work on that.

@AMontagu AMontagu added the invalid This doesn't seem right label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legau legau Awaiting requested review from legau

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generated PartialUpdate and Response protos should not have pk as optional
1 participant
@AMontagu