Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated PartialUpdate and Response protos should not have pk as optional #281

Open
legau opened this issue Apr 8, 2024 · 1 comment · May be fixed by #284
Open

Generated PartialUpdate and Response protos should not have pk as optional #281

legau opened this issue Apr 8, 2024 · 1 comment · May be fixed by #284
Assignees
Labels
bug Something isn't working

Comments

@legau
Copy link
Contributor

legau commented Apr 8, 2024

When generating protos with a PartialUpdate we get :

message SomethingPartialUpdateRequest {
    optional string uuid = 1;
    ...
}
message SomethingResponse {
    optional string uuid = 1;
    ...
}

These pk fields should be required

@legau legau added the bug Something isn't working label Apr 8, 2024
@AMontagu AMontagu self-assigned this Apr 8, 2024
@AMontagu
Copy link
Collaborator

AMontagu commented Apr 8, 2024

As discussed we keep otional for PartialUpdate to keep same logic used for the create/update message.
If someone reaaly want to have the lookup field of the partial update not optional we recommend to manually do this logic into a GenerationPlugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants