set Access-Control-Allow-Origin header to origin to enable withCredentials #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
see comment in client issue: |
|
Have you tested if this fixes #625 because i'm pretty sure it doesn't |
|
It should. We don't use express but we use io.set('authorization') and the problem we fixed was failed auth because of undefined req.headers.cookie |
|
It needs to be combined with the pull request I submitted to socket.io-client |
|
@3rd-Eden I've added your suggested change re our discussion: socketio/socket.io-client#335 Not sure if the merge should be part of this pull request. But check out the diff, it's all good. |
rauchg
added a commit
that referenced
this pull request
Nov 22, 2011
set Access-Control-Allow-Origin header to origin to enable withCredentials
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set Access-Control-Allow-Origin header to origin to enable withCredentials. Bug #625 and client bug socketio/socket.io-client#333