set withCredentials to true before xhr to fix authentication

[gavinuhma]

set withCredentials to true before xhr to fix authentication. Bug #333 and server bug socketio/socket.io#625

[3rd-Eden]

Looks good to me.

[3rd-Eden]

@gavinuhma actually, you also need to set the Access-Control-Allow-Credientials or you will get a shitload of Credentials flag is true, but Access-Control-Allow-Credentials is not "true". messages.

[gavinuhma]

@3rd-Eden that happens in socket.io server already. This pull request requires the pull request I submitted here:
socketio/socket.io#630

Here's the commit:
https://github.com/gavinuhma/socket.io/commit/e4a9342e8b029d8dc251f13b6320500e809c7921

[3rd-Eden]

Yeh I might have posted it in the wrong repo, but I implemented you fix in my reconnect branch (3rd-Eden@5927d41#L4R178) and it does not pass the test suite as it's giving that message Credentials flag is true, but Access-Control-Allow-Credentials is not "true". the only fix for it is remove

https://github.com/LearnBoost/socket.io/pull/630/files#L0R725 that cookie check if statement.

[gavinuhma]

aw that sounds right. our tests always had a cookie so we wouldn't have ran into that case