Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix 'key psutil not found in packageToDepTreeMap' error #165

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

admons
Copy link
Contributor

@admons admons commented Sep 9, 2021

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

In #159 we introduced a change to use dep graph instead of dep tree
In specific scenarios, we see a direct dependency more than once for a specific package.
This change will make sure we're setting it correctly

@admons admons requested a review from a team as a code owner September 9, 2021 06:53
@admons admons requested a review from orsagie September 9, 2021 06:53
@admons admons force-pushed the fix/repeating-dependency branch 2 times, most recently from 5fa55b5 to aac5b34 Compare September 9, 2021 07:39
In #159 we introduced a change to use dep graph instead of dep tree
In specific scenarios, we see a direct dependency more than once for a specific package.
This change will make sure we're setting it correctly
@admons admons force-pushed the fix/repeating-dependency branch from aac5b34 to d5d8433 Compare September 9, 2021 07:54
Copy link
Contributor

@jan-stehlik jan-stehlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌

@admons admons merged commit 7033b60 into master Sep 9, 2021
@admons admons deleted the fix/repeating-dependency branch September 9, 2021 08:24
@snyksec
Copy link

snyksec commented Sep 9, 2021

🎉 This PR is included in version 1.22.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

admons added a commit to snyk/cli that referenced this pull request Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants