feat: return depgraph from plugin #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
96cf604 to
dd01624
Compare
jan-stehlik
approved these changes
Aug 12, 2021
Comment on lines
+837
to
+843
| .then(async (result) => { | ||
| const dependencyGraph = result.dependencyGraph; | ||
| const pkg = await depGraphLib.legacy.graphToDepTree( | ||
| dependencyGraph, | ||
| 'pip' | ||
| ); | ||
| t.ok(pkg.dependencies, 'does not error'); |
There was a problem hiding this comment.
these are a bit cheeky assertions haha, but lgtm
28b21d7 to
35f3749
Compare
this change will return a depgraph instead of a deptree from the plugin because a package can only have one version, it doesn't make sense to create it more than once in "pip_resolve.py" script this change will remove the duplicates from the scripts and replace them with a "true" value later the "buildDepGraph" function will iterate over the tree and replace all "true" values with a reference to the original package this will improve performance for those reasons: 1. no serializing dep tree with repeating dependencies 2. no deserializing repeating dependencies (memory and cpu affects) 3. return a depGraph
35f3749 to
d58d135
Compare
|
🎉 This PR is included in version 1.21.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 task
admons
added a commit
that referenced
this pull request
Sep 9, 2021
In #159 we introduced a change to use dep graph instead of dep tree In specific scenarios, we see a direct dependency more than once for a specific package. This change will make sure we're setting it correctly
3 tasks
admons
added a commit
that referenced
this pull request
Sep 9, 2021
In #159 we introduced a change to use dep graph instead of dep tree In specific scenarios, we see a direct dependency more than once for a specific package. This change will make sure we're setting it correctly
admons
added a commit
that referenced
this pull request
Sep 9, 2021
In #159 we introduced a change to use dep graph instead of dep tree In specific scenarios, we see a direct dependency more than once for a specific package. This change will make sure we're setting it correctly
admons
added a commit
that referenced
this pull request
Sep 9, 2021
In #159 we introduced a change to use dep graph instead of dep tree In specific scenarios, we see a direct dependency more than once for a specific package. This change will make sure we're setting it correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
this change will return a depgraph instead of a deptree from the plugin