Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

package not compiling with the latest aeson version (2.2.0.0) #219

Closed
fnurglewitz opened this issue Jun 29, 2023 · 2 comments · Fixed by #220
Closed

package not compiling with the latest aeson version (2.2.0.0) #219

fnurglewitz opened this issue Jun 29, 2023 · 2 comments · Fixed by #220

Comments

@fnurglewitz
Copy link

The latest aeson version (2.2.0.0) removed the Data.Aeson.Internal module, thus causing compilation errors for the yaml package:

[ 1 of 10] Compiling Data.Yaml.Internal ( src/Data/Yaml/Internal.hs, dist/build/Data/Yaml/Internal.o, dist/build/Data/Yaml/Internal.dyn_o )

src/Data/Yaml/Internal.hs:49:1: error:
    Could not find module ‘Data.Aeson.Internal’
    Perhaps you meant
      Data.Aeson.Internal.TH
      Data.Set.Internal (from containers-0.6.5.1)
      Data.Text.Internal (needs flag -package-id text-1.2.5.0)
@jgm
Copy link
Contributor

jgm commented Jun 29, 2023

They dropped the Data.Aeson.Internal module: it was apparently intentional (haskell/aeson#993) but didn't get noted in the changelog. I sincerely hope there's a way around this. If not, perhaps worth begging to have it reinstated!

@jgm
Copy link
Contributor

jgm commented Jun 29, 2023

It would be good, in the mean time, if an aeson upper bound (< 2.2.0.0) could be added as a Hackage revision.

jgm added a commit to jgm/yaml that referenced this issue Jun 29, 2023
@jgm
Allow compilation with aeson 2.2.0.0.
3ec4100 
This version of aeson removes Data.Aeson.Internal, but exports the
things yaml needed from it in Data.Aeson.Types.

CPP has been used to make it work with both 2.2 and earlier versions.
However, I was only able to test with aeson 2.1; attempts to constrain
the build to earlier versions did not produce a viable build path.

Closes snoyberg#219.
@jgm jgm mentioned this issue Jun 29, 2023
Merged
@ulysses4ever ulysses4ever mentioned this issue Jun 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow compilation with aeson 2.2.0.0. jgm/yaml
2 participants
@jgm @fnurglewitz