-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not always pass --quickjump
to haddock (backport #9049)
#9073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The conflict is due to reformatting. |
(cherry picked from commit 7b1a693)
173d7fc
to
3faee44
Compare
fix-whitespace job fails because fix-whitespace's dependency fail: snoyberg/yaml#219 Maybe we have to merge as is. |
I want to try something with |
@ulysses4ever alright we are good! |
ulysses4ever
approved these changes
Jun 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Terrific!
2 tasks
liskin
added a commit
to xmonad/X11
that referenced
this pull request
Nov 12, 2023
Cabal 3.10.2.0 exposes a bug in Haddock shipped with GHC 9.0 and 9.2, so we need to work around it by bumping the version of GHC/Haddock we use for building/uploading docs to Hackage, and to prevent build failures we don't ever try to build haddocks for Hackage with older versions of GHC/Haddock. Related: haskell/haddock#1582 (comment) Related: haskell/cabal#8326 Related: haskell/cabal#9060 Related: haskell/cabal#9073 Related: haskell/cabal#9049
liskin
added a commit
to xmonad/X11-xft
that referenced
this pull request
Nov 12, 2023
Cabal 3.10.2.0 exposes a bug in Haddock shipped with GHC 9.0 and 9.2, so we need to work around it by bumping the version of GHC/Haddock we use for building/uploading docs to Hackage, and to prevent build failures we don't ever try to build haddocks for Hackage with older versions of GHC/Haddock. Related: haskell/haddock#1582 (comment) Related: haskell/cabal#8326 Related: haskell/cabal#9060 Related: haskell/cabal#9073 Related: haskell/cabal#9049
liskin
added a commit
to xmonad/xmonad
that referenced
this pull request
Nov 12, 2023
Cabal 3.10.2.0 exposes a bug in Haddock shipped with GHC 9.0 and 9.2, so we need to work around it by bumping the version of GHC/Haddock we use for building/uploading docs to Hackage, and to prevent build failures we don't ever try to build haddocks for Hackage with older versions of GHC/Haddock. Related: haskell/haddock#1582 (comment) Related: haskell/cabal#8326 Related: haskell/cabal#9060 Related: haskell/cabal#9073 Related: haskell/cabal#9049
liskin
added a commit
to xmonad/xmonad-contrib
that referenced
this pull request
Nov 12, 2023
Cabal 3.10.2.0 exposes a bug in Haddock shipped with GHC 9.0 and 9.2, so we need to work around it by bumping the version of GHC/Haddock we use for building/uploading docs to Hackage, and to prevent build failures we don't ever try to build haddocks for Hackage with older versions of GHC/Haddock. Related: haskell/haddock#1582 (comment) Related: haskell/cabal#8326 Related: haskell/cabal#9060 Related: haskell/cabal#9073 Related: haskell/cabal#9049
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #9049 done by Mergify.
Cherry-pick of 7b1a693 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com