fix: Populate ImagePullSecrets in Adapter Deployment and Add Correspo…

…nding Tests (kaito-project#656)

**Reason for Change**:
fix the bug that adapter with ImagePullSecrets will not be populated to
its deployment

**Requirements**

- [x] added unit tests and e2e tests (if applicable).

**Issue Fixed**:
<!-- If this PR fixes GitHub issue 4321, add "Fixes #4321" to the next
line. -->

**Notes for Reviewers**:

---------

Co-authored-by: qfai <quke@microsoft.com>
Co-authored-by: Fei Guo <guofei@microsoft.com>

pkg/inference/preset-inferences.go

@@ -109,6 +109,13 @@ func GetInferenceImageInfo(ctx context.Context, workspaceObj *kaitov1alpha1.Work
 		imageTag := presetObj.Tag
 		registryName := os.Getenv("PRESET_REGISTRY_NAME")
 		imageName = fmt.Sprintf("%s/kaito-%s:%s", registryName, imageName, imageTag)
+		if len(workspaceObj.Inference.Adapters) > 0 {
+			for _, adapter := range workspaceObj.Inference.Adapters {
+				for _, secretName := range adapter.Source.ImagePullSecrets {
+					imagePullSecretRefs = append(imagePullSecretRefs, corev1.LocalObjectReference{Name: secretName})
+				}
+			}
+		}
 		return imageName, imagePullSecretRefs
 	}
 }

pkg/inference/preset-inferences_test.go

@@ -83,13 +83,14 @@ func TestCreatePresetInference(t *testing.T) {
 
 			workspace := test.MockWorkspaceWithPreset
 			workspace.Resource.Count = &tc.nodeCount
-
+			expectedSecrets := []string{"fake-secret"}
 			if tc.hasAdapters {
 				workspace.Inference.Adapters = []v1alpha1.AdapterSpec{
 					{
 						Source: &v1alpha1.DataSource{
-							Name:  "Adapter-1",
-							Image: "fake.kaito.com/kaito-image:0.0.1",
+							Name:             "Adapter-1",
+							Image:            "fake.kaito.com/kaito-image:0.0.1",
+							ImagePullSecrets: expectedSecrets,
 						},
 						Strength: &ValidStrength,
 					},
@@ -151,6 +152,19 @@ func TestCreatePresetInference(t *testing.T) {
 
 			// Check for adapter volume
 			if tc.hasAdapters {
+				var actualSecrets []string
+				if tc.workload == "Deployment" {
+					for _, secret := range createdObject.(*appsv1.Deployment).Spec.Template.Spec.ImagePullSecrets {
+						actualSecrets = append(actualSecrets, secret.Name)
+					}
+				} else {
+					for _, secret := range createdObject.(*appsv1.StatefulSet).Spec.Template.Spec.ImagePullSecrets {
+						actualSecrets = append(actualSecrets, secret.Name)
+					}
+				}
+				if !reflect.DeepEqual(expectedSecrets, actualSecrets) {
+					t.Errorf("%s: ImagePullSecrets are not expected, got %v, expect %v", k, actualSecrets, expectedSecrets)
+				}
 				found := false
 				for _, volume := range createdObject.(*appsv1.Deployment).Spec.Template.Spec.Volumes {
 					if volume.Name == tc.expectedVolume {

test/e2e/inference_with_adapters_test.go

@@ -40,6 +40,9 @@ var validAdapters2 = []kaitov1alpha1.AdapterSpec{
 		Source: &kaitov1alpha1.DataSource{
 			Name:  imageName2,
 			Image: fullImageName2,
+			ImagePullSecrets: []string{
+				aiModelsRegistrySecret,
+			},
 		},
 		Strength: &DefaultStrength,
 	},
@@ -82,6 +85,9 @@ func validateInitContainers(workspaceObj *kaitov1alpha1.Workspace, expectedInitC
 				return false
 			}
 
+			if dep.Spec.Template.Spec.ImagePullSecrets == nil || len(dep.Spec.Template.Spec.ImagePullSecrets) == 0 {
+				return false
+			}
 			if len(initContainers) != len(expectedInitContainers) {
 				return false
 			}