fix: Populate ImagePullSecrets in Adapter Deployment and Add Corresponding Tests #656
+30
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be populated to deployment
added 3 commits
October 29, 2024 16:25
Fei-Guo
approved these changes
Oct 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #656 +/- ##
==========================================
- Coverage 58.18% 52.89% -5.29%
==========================================
Files 30 34 +4
Lines 2987 4225 +1238
==========================================
+ Hits 1738 2235 +497
- Misses 1149 1870 +721
- Partials 100 120 +20 ☔ View full report in Codecov by Sentry. |
smritidahal653
pushed a commit
to smritidahal653/kaito
that referenced
this pull request
Nov 14, 2024
…nding Tests (kaito-project#656) **Reason for Change**: fix the bug that adapter with ImagePullSecrets will not be populated to its deployment **Requirements** - [x] added unit tests and e2e tests (if applicable). **Issue Fixed**: <!-- If this PR fixes GitHub issue 4321, add "Fixes #4321" to the next line. --> **Notes for Reviewers**: --------- Co-authored-by: qfai <quke@microsoft.com> Co-authored-by: Fei Guo <guofei@microsoft.com>
zhuangqh
pushed a commit
that referenced
this pull request
Nov 15, 2024
…nding Tests (#656) **Reason for Change**: fix the bug that adapter with ImagePullSecrets will not be populated to its deployment **Requirements** - [x] added unit tests and e2e tests (if applicable). **Issue Fixed**: <!-- If this PR fixes GitHub issue 4321, add "Fixes #4321" to the next line. --> **Notes for Reviewers**: --------- Co-authored-by: qfai <quke@microsoft.com> Co-authored-by: Fei Guo <guofei@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
fix the bug that adapter with ImagePullSecrets will not be populated to its deployment
Requirements
Issue Fixed:
Notes for Reviewers: