-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing support for Python 3.8 #289
Removing support for Python 3.8 #289
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, is it waiting onanything @timryanb ?
Also, can we make a new release when this is merged?
I'd like to get @gjkennedy approval before merging this in. I'd also like to give people a heads up at the group meeting as I don't know if any of our developers are on 3.8 |
@A-CGray, yes I agree that we should do version update after merging this in. We should also merge any other outstanding PRs with this as well. We can discuss more at the dev meeting |
oldest-supported-numpy
is being deprecated since numpy 1.25+ now defaults to using a consistent C-API that should always be backwards compatible (see reales notes here)