Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing support for Python 3.8 #289

Merged
merged 12 commits into from
Mar 11, 2024

Conversation

timryanb
Copy link
Collaborator

@timryanb timryanb commented Jan 5, 2024

  • Python 3.8 will reach end of life in October. While there's still a couple months left until this happens some of our dependencies (numpy and pynastran) have already dropped support for it
  • I think we should consider removing support for 3.8 early, as maintaining it is becoming more difficult due to the point above.
  • This PR will remove support for Python 3.8 and makes the following changes:
    • oldest-supported-numpy is being deprecated since numpy 1.25+ now defaults to using a consistent C-API that should always be backwards compatible (see reales notes here)
    • pyNastran released a new update this week which fixes several long-standing errors with processing dynamic loads. I've pinned this version as the new minimum in the setup.py
    • CI Python version has been bumped to 3.9

@timryanb timryanb changed the title Removing oldest numpy from build dependencies Bumping minimum supported Python to 3.9 Mar 1, 2024
@timryanb timryanb mentioned this pull request Mar 1, 2024
@timryanb timryanb changed the title Bumping minimum supported Python to 3.9 Removing support for Python 3.8 Mar 1, 2024
@timryanb timryanb requested review from A-CGray and gjkennedy March 1, 2024 18:55
Copy link
Contributor

@A-CGray A-CGray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, is it waiting onanything @timryanb ?

Also, can we make a new release when this is merged?

@timryanb
Copy link
Collaborator Author

timryanb commented Mar 6, 2024

This looks good to me, is it waiting onanything @timryanb ?

Also, can we make a new release when this is merged?

I'd like to get @gjkennedy approval before merging this in. I'd also like to give people a heads up at the group meeting as I don't know if any of our developers are on 3.8

@timryanb
Copy link
Collaborator Author

timryanb commented Mar 7, 2024

@A-CGray, yes I agree that we should do version update after merging this in. We should also merge any other outstanding PRs with this as well. We can discuss more at the dev meeting

@timryanb timryanb marked this pull request as ready for review March 11, 2024 14:44
@timryanb timryanb merged commit 2e339f2 into smdogroup:master Mar 11, 2024
5 checks passed
@timryanb timryanb deleted the oldest-numpy-deprecation branch March 11, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants