Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing support for Python 3.8 #294

Merged
merged 4 commits into from
Mar 11, 2024
Merged

Conversation

timryanb
Copy link
Collaborator

  • Python 3.8 will reach end of life in October. While there's still a couple months left until this happens some of our dependencies (numpy and pynastran) have already dropped support for it
  • We are removing support for 3.8 early, as maintaining it is becoming more difficult due to the point above. Support in TACS has already been removed
  • See TACS PR #289 for more info

Copy link
Contributor

@sean-engelstad sean-engelstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just concerned about the python 3.12 with conda.

- 3.9
- 3.10
- 3.11
- 3.12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last time I tested python 3.12 with the conda build of funtofem it didn't work.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also ran into issues building against 3.12 when it first came out. It tends to take a while for all of our dependencies to upgrade their conda packages for new Python versions.

That said, a 3.12 build for funtofem will definitely fail at the moment since TACS doesn't have any Python 3.12 conda packages (and tacs is listed as a dependency for funtofem in the conda recipe). I tested out building a conda package for tacs on 3.12 this morning and seemed to have success. So 3.12 support should be available on the tacs side with the new tacs version bump this week.

@timryanb timryanb merged commit 6721349 into smdogroup:master Mar 11, 2024
6 checks passed
@timryanb timryanb deleted the ci-python-3_9 branch March 11, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants