Updated Protocol Enums to Match Spec #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: Although these are technically major changes, all files involved will be removed from public view before v5.0 launches. |
…protocol_spec_enums * origin/develop: Update for v4.5.1 Added a ParameterAssert instead of throwing an exception, along with returning a handler with an error. Updated to throw an exception instead of returning an error for nil requests being sent. Adding a spec to test sending nil request. Added check for nil request in sending. Fixed issue around not calculating an SDLPutFile's currentOffset correctly. Updated unit tests to cover all SDLPutFiles, not just the first. Added in missing implementations of dictionary categories. Moved the import from SDLRPCStruct to implementation of all classes to remove build warning of redefinition Removed nonexistent files from project Added nullability annotations. Fixed issue using incorrect name for search address. Migrated to using a category instead of adding the classes to the subclass of SDLRPCStruct. Updated missing parameters. Updated setter/getter for all rpcs and structs to use convenience methods.
…protocol_spec_enums * origin/develop: Fixed renamed variable in unit tests.
…protocol_spec_enums * origin/develop: Removed unused property in unit test.
…protocol_spec_enums * origin/develop: Fixed issue with incorrectly parsing SDLRPCResponses.
Current coverage is 9.92% (diff: 4.08%)
|
joeljfischer
suggested changes
Jan 23, 2017
| typedef NS_ENUM(UInt8, SDLFrameInfo) { | ||
| SDLFrameInfoHeartbeat = 0x00, | ||
| SDLFrameInfoStartService = 0x01, | ||
| SDLFrameInfoStartServiceAck = 0x02, |
There was a problem hiding this comment.
ACK and NACK should still be uppercase. They are based on the TCP ACK and NACK, which are uppercased.
…protocol_spec_enums * origin/develop: (28 commits) Fixed issue with tests not compiling after merging master into develop. Fixed issue with retain cycle within the dispatch_after block. Fix double semi-colon Re-add reconnecting state Don’t auto-reconnect in example project Cleaned up ProxyManager startWithReadyHandler: In order to restart properly, we need to start only after managerDidDisconnect (per new documentation). Adding a fix to restarting the proxy around an Apple Bug. Adding a note about stopping SDLManager. Removing Reconnecting state and instead using started. Updated lifecycle manager states to handle stopping the manager correctly. Remove NSMutableDictionary+Store.h from podspec Revert "Updated SDLManagerError enum to include a warning case." Updated SDLManagerError enum to include a warning case. Fixed issue with test case not passing. Update with changes to make registration handling testable Actual failure in registration now calls the readyHandler Make `NSMutableDictionary+Store.h` private Fixed issue with stopping the proxy didn't actually stop it. Don’t loop over enums when we don’t have to ...
joeljfischer
approved these changes
Jan 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #275
This PR is ready for review.
Risk
This PR makes major API changes.
Testing Plan
This will use the existing unit tests, as we just renamed enum values.
Summary
Changed names of
SDLProtocolHeaderenums to match the spec and make them easier to use in swift.Changelog
Breaking Changes
SDLProtocolHeaderenums to match the spec and make them easier to use in swift.Enchancements
SDLProtocolHeaderenums to match the spec and make them easier to use in swift.