Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy enums and variable names don't match protocol spec #275

Closed
joeljfischer opened this issue Aug 7, 2015 · 1 comment
Closed

Proxy enums and variable names don't match protocol spec #275

joeljfischer opened this issue Aug 7, 2015 · 1 comment
Labels
best practice Not a defect but something that should be improved anyway documentation Relating to inline documentation
Milestone
5.0.0

Comments

@joeljfischer
Copy link
Contributor

For instance: SDLProtocolHeader enum SDLFrameData doesn't match the protocol spec.

"Frame Data" should be "Frame Info", "Start Session" should be "Start Service".
@joeljfischer joeljfischer added documentation Relating to inline documentation best practice Not a defect but something that should be improved anyway labels Aug 7, 2015
@joeljfischer joeljfischer added this to the 4.0.1 milestone Aug 7, 2015
@joeljfischer joeljfischer modified the milestones: 5.0.0, 4.0.X Jan 19, 2016
This was referenced Jan 19, 2017
Closed
Merged
@joeljfischer
Copy link
Contributor Author

Fixed in v5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
best practice Not a defect but something that should be improved anyway documentation Relating to inline documentation
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
1 participant
@joeljfischer