Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attributed strings can be used as picker rows. Fixed accessibility for picker title. #403

Merged
merged 17 commits into from
Dec 1, 2019

Conversation

xjki
Copy link
Collaborator

@xjki xjki commented Oct 3, 2018

In addition to changes mentioned in title also fixed issues (+converted to Swift 4.2) Swift-Example target, added comments and cleanup to make examples more clear.

@skywinder skywinder self-requested a review November 30, 2019 06:38
Copy link
Owner

@skywinder skywinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. THank you for the fixes, @xjki 👍

@skywinder
Copy link
Owner

@xjki You've done a huge work with bunch of optimisations. thank you very much! 👍

@skywinder skywinder merged commit 01fa654 into skywinder:develop Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants