Attributed strings can be used as picker row titles. #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skywinder
reviewed
Nov 21, 2017
| * @param successAction | ||
| * @param indexes is used to establish the initially selected rows; | ||
| * @param target must not be empty. It should respond to "onSuccess" actions. | ||
| * @param successAction successActin |
Pickers/ActionSheetStringPicker.m
Outdated
|
|
||
| NSAttributedString *attributeTitle = [self pickerView:pickerView attributedTitleForRow:row forComponent:component]; |
There was a problem hiding this comment.
👍 great. seems it should works! Please fix typo above and I will happy to merge!
skywinder
requested changes
Nov 21, 2017
Fix run ActionSheetPickerTests on Xcode and Travis CI
|
Please delete this request. Created another pull request #403 |
… for Swift example.
… migrated to Swift 4.2. Fixed target warnings in Xcode 10.
…lf retain and depreceated ObjC impelementations.
… pickers in dark modes).
# Conflicts: # .travis.yml # Example Projects/Swift-Example/Swift-Example.xcodeproj/project.pbxproj
skywinder
requested changes
Nov 30, 2019
| # xcode_workspace: ActionSheetPicker-3.0.xcworkspace | ||
| # xcode_scheme: ActionSheetPickerTests | ||
| # xcode_sdk: iphonesimulator | ||
|
|
||
| notifications: | ||
| email: | ||
| recipients: | ||
| - sky4winder+actionSheetPicker@gmail.com | ||
| - jki@jki.lv |
There was a problem hiding this comment.
🧐 Travis is not worked correctly yet. If you want to setup it - please make a list of recipients
| @@ -208,13 +208,6 @@ - (BOOL)prefersStatusBarHidden { | |||
| return [UIApplication sharedApplication].statusBarHidden; | |||
| } | |||
|
|
|||
| - (BOOL)shouldAutorotateToInterfaceOrientation:(UIInterfaceOrientation)interfaceOrientation | |||
There was a problem hiding this comment.
Are you sure, that we can delete this check? I added it to fix something (shame of me, didn't put comment there).. But still.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request allows to provide attributed strings (eg text with icon) as picker rows.
Also fixed documentation warnings and accessibility for picker title.