Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #1 Support wrap content & padding instead of height/width dp #20

Merged
merged 5 commits into from
Mar 20, 2020

Conversation

skydoves
Copy link
Owner

@skydoves skydoves commented Mar 20, 2020

Guidelines

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce?

  • New feature (non-breaking change which adds functionality)

Wrap content & padding instead of height/width dp.

# Conflicts:
#	app/src/main/java/com/skydoves/balloondemo/factory/ProfileBalloonFactory.kt
#	app/src/main/java/com/skydoves/balloondemo/factory/TagBalloonFactory.kt
#	app/src/main/res/layout/layout_custom_tag.xml
#	balloon/src/main/java/com/skydoves/balloon/Balloon.kt
@skydoves skydoves added the Release Next This feature will be released on next version label Mar 20, 2020
@skydoves skydoves self-assigned this Mar 20, 2020
@skydoves skydoves merged commit 6b4c270 into master Mar 20, 2020
@skydoves skydoves deleted the feature/wrap_content branch March 20, 2020 12:01
@jeevansurendran
Copy link

Hey @skydoves , how soon can I expect this feature being added to your next release ?

@jeevansurendran
Copy link

Thank you ! Any ideas how could i get a shadow effect for the baloon?

@skydoves
Copy link
Owner Author

Released in 1.1.2.
Do you mean this dimming effect #14 on the background?

@skydoves skydoves added Released Released already on the latest version. and removed Release Next This feature will be released on next version labels Mar 20, 2020
@jeevansurendran
Copy link

Some what similar to this one
You could see a shadow effect below. I want to bring a similar effect. Should I acheive this using a drawable or is there something supported by the library

@skydoves
Copy link
Owner Author

Thank you for your idea!
It is already to be featured in the next release :)

screenshot555192197

@skydoves
Copy link
Owner Author

#21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Released Released already on the latest version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants