Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support padding instead of height/width dp #1

Closed
LithiumSheep opened this issue Jul 24, 2019 · 7 comments
Closed

Support padding instead of height/width dp #1

LithiumSheep opened this issue Jul 24, 2019 · 7 comments
Assignees

Comments

@LithiumSheep
Copy link

Is your feature request related to a problem?

For a balloon with multiple lines of text, having the balloon container scale with its height would be very useful.

Describe the solution you'd like:

At the moment the layout_balloon.xml file uses dp values instead of "wrap_content". If the layout uses "wrap_content" for height, the builder can drop builder.setHeight() and builder.setWidth(), and instead have something like builder.setPaddingVert() and builder.setPaddingHoriz().

Thoughts?

skydoves pushed a commit that referenced this issue Jul 25, 2019
@skydoves
Copy link
Owner

@lolsheeplol
It seems a good way to scaling container.

I will try to implement to scale container size using padding and "wrap_content" layout attribute
on the next version.

Thank you for giving a good issue! :)

@rgocal
Copy link

rgocal commented Sep 3, 2019

I was just going to ask about this. The problem i have right now is i have a list that changes size vertical depending on options available for the action. What i have to currently do is set a default height and add to that height when the listview has so many objects (1 action + add x height, 2 actions add xy height). I've even tried getting the view group height from tree observer to set that as the height but it adds to that value every time its calculated. Having a height option to wrap around the xml would be good.

@skydoves
Copy link
Owner

skydoves commented Sep 4, 2019

Hi, is there a better way to implement having a height option to wrap around the xml with keeping functionalities like showAlignTop? It uses a fixed height with bodyWindow.showAsDropDown.
If the layout uses "wrap_content" option, we can't measure the specific height values.
Because of the popupWindow shows firstly and inflates the popupWindow 's content view.

@rgocal
Copy link

rgocal commented Sep 7, 2019

https://github.com/rgocal/Material_PopUp_Menu

You can check and see if there's anything helpful, you could use from my popup menu library. (im actually replacing my library with yours for my project)

@rustyhamsterr
Copy link
Contributor

@skydoves Hi, I am using your library right now and want to improve it. I think using wrap content is a very important function and I wanted to start with this.
Did you make progress since this issue was opened?
Greetings rusty

@skydoves skydoves added the enhancement New feature or request label Jan 29, 2020
@skydoves skydoves self-assigned this Jan 29, 2020
@skydoves skydoves added Release Next This feature will be released on next version WIP Work In Progress and removed enhancement New feature or request labels Mar 19, 2020
@skydoves
Copy link
Owner

#20

@skydoves skydoves removed Release Next This feature will be released on next version WIP Work In Progress labels Mar 20, 2020
@skydoves
Copy link
Owner

It has been a long time! The first issue is resolved in the new release 1.1.2. 🎉

skydoves pushed a commit that referenced this issue Dec 21, 2023
Change arrow positioning logic for ArrowPositionRules.ALIGN_ANCHOR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants