Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

singleSpaReact’s domElementGetter function No arguments? #71

Closed
yuanman0109 opened this issue Apr 3, 2020 · 4 comments
Closed

singleSpaReact’s domElementGetter function No arguments? #71

yuanman0109 opened this issue Apr 3, 2020 · 4 comments

Comments

@yuanman0109
Copy link

If there's a scenario like this,child app need root app pass a parameter to judge mount which one dom。example:
image

I hope to get the props,but ,Does not support now;Is there any other way?

@joeldenning
Copy link
Member

Hi @yuanman0109 - right now single-spa-react does not pass the single-spa props to the dom element getter. The props are only passed to the lifecycle functions, not the dom element getter.

I'd be okay adding this feature to single-spa-react, though, and will put together a PR to add it. I will transfer this issue to single-spa-react.

@joeldenning
Copy link
Member

@yuanman0109
Copy link
Author

This is now supported in https://github.com/single-spa/single-spa-react/releases/tag/v2.13.0

very very good, I didn't expect to be so efficient;The reason why need props is because my child component both as a pop-up box and as a router page, so I need it to judge;Thank you very much for supporting this feature;Do I need to upgrade the single-spa-react?

@joeldenning
Copy link
Member

Yes you must upgrade to single spa react 2.13.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants