Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send the props object to the domElementGetter function #44

Closed
andrefrua opened this issue May 12, 2020 · 5 comments
Closed

Send the props object to the domElementGetter function #44

andrefrua opened this issue May 12, 2020 · 5 comments

Comments

@andrefrua
Copy link
Contributor

Hello,
Would be it possible to make a change here:

element = opts.domElementGetter();

So that the domElementGetter receive the props?

A similar change was made for the react version here:
single-spa/single-spa-react#71

Thank you

@joeldenning
Copy link
Member

Hi @andrefrua, sure I'm open to that change. Here is the relevant line of code:

element = opts.domElementGetter();

Could you submit a pull request to add this?

@andrefrua
Copy link
Contributor Author

Sure :)
Here it is:
#45

@joeldenning
Copy link
Member

Thanks! This is released in https://github.com/single-spa/single-spa-angularjs/releases/tag/v3.3.0.

Could you send a pull request to update the documentation for this? You can modify it at https://github.com/single-spa/single-spa.js.org/edit/master/website/versioned_docs/version-5.x/ecosystem-angularjs.md

@andrefrua
Copy link
Contributor Author

Here it is: single-spa/single-spa.js.org#254

Let me know if it's ok :)

@joeldenning
Copy link
Member

👍 looks great, thanks. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants