-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send the props
object to the domElementGetter function
#44
Comments
Hi @andrefrua, sure I'm open to that change. Here is the relevant line of code:
Could you submit a pull request to add this? |
Sure :) |
Thanks! This is released in https://github.com/single-spa/single-spa-angularjs/releases/tag/v3.3.0. Could you send a pull request to update the documentation for this? You can modify it at https://github.com/single-spa/single-spa.js.org/edit/master/website/versioned_docs/version-5.x/ecosystem-angularjs.md |
Here it is: single-spa/single-spa.js.org#254 Let me know if it's ok :) |
👍 looks great, thanks. Closing this issue. |
Hello,
Would be it possible to make a change here:
single-spa-angularjs/src/single-spa-angularjs.js
Line 109 in 931d108
So that the domElementGetter receive the props?
A similar change was made for the react version here:
single-spa/single-spa-react#71
Thank you
The text was updated successfully, but these errors were encountered: