Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TDL-19742 Run discover mode if catalog is not given in sync mode #85

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tap_google_sheets/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,10 @@ def main():

if parsed_args.discover:
do_discover(client, spreadsheet_id)
elif parsed_args.catalog:
else:
sync(client=client,
config=config,
catalog=parsed_args.catalog,
catalog=parsed_args.catalog or discover(client, spreadsheet_id),
state=state)

if __name__ == '__main__':
Expand Down
34 changes: 34 additions & 0 deletions tests/unittests/test_catalog_in_sync.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
import unittest
from unittest import mock
from tap_google_sheets import main


class MockedParseArgs:
discover = False
config = {"client_id":"", "client_secret": "", "refresh_token": "", "user_agent": ""}
state = False
catalog = "test"

@mock.patch("tap_google_sheets.discover")
@mock.patch("tap_google_sheets.singer.utils.parse_args", return_value=MockedParseArgs)
@mock.patch("tap_google_sheets.GoogleClient.__enter__", return_value="test")
@mock.patch("tap_google_sheets.sync")
class TestCatalog(unittest.TestCase):
def test_catalog_is_given_in_sync(self, mocked_sync, mocked_google_client, mocked_parse_args, mocked_discover):
"""
To verify that if catalog is given in sync mode then run with catalog file
"""
main()
mocked_sync.assert_called_with(client="test", config=MockedParseArgs.config, catalog="test", state={})
self.assertEqual(mocked_discover.call_count, 0, "discover function is not called expected times")

def test_catalog_is_not_given_in_sync(self, mocked_sync, mocked_google_client, mocked_parse_args, mocked_discover):
"""
To verify that if catalog is not given in sync mode then run discover mode to generate catalog
"""
# mocking discover function
MockedParseArgs.catalog = ""
mocked_discover.return_value = "test"
main()
mocked_sync.assert_called_with(client="test", config=MockedParseArgs.config, catalog="test", state={})
self.assertEqual(mocked_discover.call_count, 1, "discover function is not called expected times")