TDL-19742 Run discover mode if catalog is not given in sync mode #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savan-chovatiya
suggested changes
Jul 1, 2022
| @@ -0,0 +1,38 @@ | |||
| from shutil import ExecError | |||
There was a problem hiding this comment.
Remove this unused import
There was a problem hiding this comment.
Removed unused imported packages.
Comment on lines
23
to
24
| mocked_parse_args.return_value = MockedParseArgs | ||
| mocked_google_client.return_value = "test" |
There was a problem hiding this comment.
Move these two lines at the @mock.patch decorator level.
There was a problem hiding this comment.
Added return_value at decorator level and removed it from the test function
| mocked_parse_args.return_value = MockedParseArgs | ||
| mocked_google_client.return_value = "test" | ||
| main() | ||
| mocked_sync.assert_called_with(client="test", config=MockedParseArgs.config, catalog="test", state={}) |
There was a problem hiding this comment.
Add additional assertion like discover() should be called for 0 or 1 times.
There was a problem hiding this comment.
Added assertion to check whether or not sync function calls discover()
savan-chovatiya
approved these changes
Jul 1, 2022
RushiT0122
approved these changes
Jul 15, 2022
shantanu73
approved these changes
Jul 18, 2022
cosimon
approved these changes
Jul 19, 2022
Merged
RushiT0122
pushed a commit
that referenced
this pull request
Sep 1, 2022
* TDL-19742 Run discover mode if catalog is not given in sync mode (#85) * TDL-19742 Run discover mode if catalog is not given in sync mode * Add call count assertion and remove unused import Co-authored-by: Jay Tilala <jay.tilala@CDSYS.LOCAL> * TDL-14450: fix inconsistency of empty cell for boolean (#84) * handled empty value scenario for the booleans * Added unit test for null value in boolean * Removed workaround from the integration test Co-authored-by: harshpatel4crest <harsh.patel4@crestdatasys.com> * TDL-14449: Syncs do not parse datetime values in number datatyped columns as strings (#83) * updated the code to store datetime values as string in numberType column * updated the test cases and handled boolean in numberType * updated code for handling numberType values * updated code to handle number format and int exponential values * added comments for transforming number format data * updated datatype integration test * resolved comments * resolved comments * updated comments * updated comments * handled duplicate code in transform numberType values * added comments * added logger and removed redundant arg * updated unittest and code * updated comment * updated bug id test case * TDL-19029: Add support for data collection from the shared drives (#80) * TDL-17517 - Add missing tap-tester cases (#65) * Added missing test cases * Updated standard bookmark test name * Added back bookmark for full_table stream * Updated comment * Removed bookmark test case. * TDL-17698: Dict based to class based refactoring (#66) * refactored code to class based * resolve unittest failure * updated the code to write state after syncing records for file metadata stream * added code change to return if file is not changed * added code change to write file metadata bookmark at the end of the sync * added function comments * created a function to get path with query params * updated code according to pylint * resolved unittest failure * TDL-19029: Add support for data collection from the shared drives * change streams.py * update README for supportsAllDrives * remove invalid datatype exception * include false as string or bool * add unitest * updated error message * change default value * update comments * update parameter name snake case * solved circleci error * update comments in unittest * Add exception for the invalid value of the supports_all_drives * optimize code as per collin suggestion * Addressed andy's comments * rename import sync name * rename import sync name * updated unittest Co-authored-by: Prijen Khokhani <88327452+prijendev@users.noreply.github.com> Co-authored-by: Harsh <80324346+harshpatel4crest@users.noreply.github.com> Co-authored-by: prijendev <prijen.khokhani@crestdatasys.com> Co-authored-by: Jay Tilala <jay.tilala@CDSYS.LOCAL> Co-authored-by: harshpatel4crest <harsh.patel4@crestdatasys.com> * added param for shared drive for all syncs (#89) Co-authored-by: jtilala <104966482+jtilala@users.noreply.github.com> Co-authored-by: Jay Tilala <jay.tilala@CDSYS.LOCAL> Co-authored-by: savan-chovatiya <80703490+savan-chovatiya@users.noreply.github.com> Co-authored-by: Prijen Khokhani <88327452+prijendev@users.noreply.github.com> Co-authored-by: prijendev <prijen.khokhani@crestdatasys.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Manual QA steps
Risks
Rollback steps