Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Update deprecations #375

Merged
merged 3 commits into from
Oct 25, 2022
Merged

API Update deprecations #375

merged 3 commits into from
Oct 25, 2022

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz mentioned this pull request Oct 18, 2022
Closed
3 tasks
GuySartorelli
GuySartorelli requested changes Oct 24, 2022
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the version numbers are incorrect - use 1 major versioning instead. Also apply to any other deprecation notices in this module.

@emteknetnz emteknetnz force-pushed the pulls/1/deprecated branch 3 times, most recently from 1f92012 to ef2a93d Compare October 25, 2022 02:34
GuySartorelli
GuySartorelli approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MOG

@GuySartorelli GuySartorelli merged commit ece9003 into silverstripe:1 Oct 25, 2022
@GuySartorelli GuySartorelli deleted the pulls/1/deprecated branch October 25, 2022 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli