Standardise deprecations in CMS4 for other core modules

[emteknetnz]

Follow on card from #10500

Process deprecations in CMS 4 for all core modules except framework

AC

• Code with a @deprecated annotation throw a Deprecation::notice()
• Code throwing a Deprecation::notice() is annotated with a @deprecated
• Normalise the @deprecated annotation ... within reason.

Implementation lessons from #10500

• Use http://github.com/emteknetnz/silverstripe-deprecator
• This will highlight deprecation messages that need to be manually changed - docblock has precedence over Deprecation::notice()
• Undo code-writing commit, manually update messages, commit, then do 2nd commit containing code-writing

Related

• Add deprecation messages in FlysystemAssetStore silverstripe-assets#521

PRs

• API Update deprecations silverstripe-admin#1384
• API Update deprecations silverstripe-asset-admin#1302
• API Update deprecations silverstripe-assets#523
• API Update deprecations silverstripe-behat-extension#228
• API Update deprecations silverstripe-campaign-admin#246
• API Update deprecations silverstripe-cms#2791
• API Update deprecations silverstripe-config#70
• API Update deprecations recipe-plugin#27
• API Update deprecations vendor-plugin#60
• API Update deprecations silverstripe-versioned#375
• API Update deprecations silverstripe-versioned-admin#259
• API Update deprecations silverstripe-elemental#1016

[GuySartorelli]

@emteknetnz
Now that the version numbers aren't actually being checked, it would be tidiest if we changed the 4.0.1 deprecation notices back to 4.0.0 - that said, there's very little benefit in that beyond pedantic correctness so I won't actually ask you to make this change, just pointing out that it's a possibility now in case you want to do it.

[GuySartorelli]

PRs are merged