Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap \PageController the base class with \SilverStripe\CMS\Controllers\ContentController #1199

Closed
wants to merge 1 commit into from
Closed

Swap \PageController the base class with \SilverStripe\CMS\Controllers\ContentController #1199

wants to merge 1 commit into from

Conversation

erikfrerejean
Copy link

closes #1198

@erikfrerejean
Swap \PageController the base class with \SilverStripe\CMS\Controller…
8a4ef29 
…s\ContentController.

`\PageController` might not exist.
@GuySartorelli
Copy link
Member

Thank you for taking the time to create a pull request, however PageController is well established as a part of Silverstripe CMS apps - it's a common patter to subclass PageController and Page in modules so that the customisations to those classes apply to the subclasses provided by the module.

I will close this PR now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UserDefinedFormController has an hard depedency on a class that might not exist
2 participants
@erikfrerejean @GuySartorelli