You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The \SilverStripe\UserForms\Control\UserDefinedFormController extends \PageController however it is never enforced that there is such a class in existance. If you add the module to an existing site that doesn't provide a \PageController itself the module happily installs but that causes problems down the line.
As the "default" \PageController from silverstripe/recipe-cms(which I assume is the reason the blind dependency exists) is nothing more then an empty shell wrapping SilverStripe\CMS\Controllers\ContentController I believe that it makes sense to have the userforms controller extend that class straight. Any required alterations can be made through an extension if needed.
The text was updated successfully, but these errors were encountered:
Thank you for taking the time to raise this issue, however PageController is well established as a part of Silverstripe CMS apps - it's a common patter to subclass PageController and Page in modules so that the customisations to those classes apply to the subclasses provided by the module.
The
\SilverStripe\UserForms\Control\UserDefinedFormController
extends\PageController
however it is never enforced that there is such a class in existance. If you add the module to an existing site that doesn't provide a\PageController
itself the module happily installs but that causes problems down the line.As the "default"
\PageController
fromsilverstripe/recipe-cms
(which I assume is the reason the blind dependency exists) is nothing more then an empty shell wrappingSilverStripe\CMS\Controllers\ContentController
I believe that it makes sense to have the userforms controller extend that class straight. Any required alterations can be made through an extension if needed.The text was updated successfully, but these errors were encountered: