ENH Use the new CMSEditLink extension on SiteTree #2778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 13, 2022
b075322 to
99ec817
Compare
99ec817 to
3682ef9
Compare
emteknetnz
requested changes
Sep 29, 2022
code/Controllers/CMSMain.php
Outdated
| * | ||
| * @see CMSEditLinkExtension::getEditLinkForManagedDataObject() | ||
| */ | ||
| public function getEditLinkForManagedDataObject(SiteTree $obj): string |
There was a problem hiding this comment.
Suggested change
| public function getEditLinkForManagedDataObject(SiteTree $obj): string | |
| public function getCMSEditLinkForManagedDataObject(SiteTree $obj): string |
code/Controllers/CMSMain.php
Outdated
| /** | ||
| * Get the link for editing a page. | ||
| * | ||
| * @see CMSEditLinkExtension::getEditLinkForManagedDataObject() |
There was a problem hiding this comment.
Suggested change
| * @see CMSEditLinkExtension::getEditLinkForManagedDataObject() | |
| * @see CMSEditLinkExtension::getCMSEditLinkForManagedDataObject() |
code/Model/SiteTree.php
Outdated
| * The class of the LeftAndMain controller where this class is managed. | ||
| * @see CMSEditLinkExtension::getCanonicalEditOwner() | ||
| */ | ||
| private static string $canonical_edit_owner = CMSMain::class; |
There was a problem hiding this comment.
Suggested change
| private static string $canonical_edit_owner = CMSMain::class; | |
| private static string $cms_edit_owner = CMSMain::class; |
3682ef9 to
c7bb8c3
Compare
|
Have merged admin PR, re-running CI |
emteknetnz
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new
CMSEditLinkextension from silverstripe/silverstripe-admin#1361 inSiteTree- this means ahas_manyrelation from some page can set the page as its canonical edit owner and itsCMSEditLink()method will automatically have a valid URL.Note
Related issue