You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ModelAdmin is a little clunky to work with at the moment - there are a few methods that don't require any instance data but aren't static, and any time you want to get a link for a managed model tab you need to re-implement the logic in sanitiseClassName() - and basically build the entire link from scratch every time with all of its component parts.
Acceptance Criteria
Methods that don't need to be instance methods should be static.
There should be an easy way to get a link for a managed model without having to reimplement sanitiseClassName().
There is a straightforward way to get a canonical edit link for objects managed by ModelAdmin
The changes are documented appropriately
Documentation that currently includes re-implementing str_replace('\\', '-', $class) is updated
These are an extended approach for resolving the "There is a straightforward way to get a canonical edit link for objects managed by ModelAdmin" acceptance criterion
ModelAdmin is a little clunky to work with at the moment - there are a few methods that don't require any instance data but aren't static, and any time you want to get a link for a managed model tab you need to re-implement the logic in
sanitiseClassName()
- and basically build the entire link from scratch every time with all of its component parts.Acceptance Criteria
sanitiseClassName()
.str_replace('\\', '-', $class)
is updatedPRs
Related PRs
These are an extended approach for resolving the "There is a straightforward way to get a canonical edit link for objects managed by ModelAdmin" acceptance criterion
The text was updated successfully, but these errors were encountered: