Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH Replace react-griddle with react-table #1546

Merged
merged 1 commit into from
Mar 5, 2025
Merged

ENH Replace react-griddle with react-table #1546

merged 1 commit into from
Mar 5, 2025

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Feb 26, 2025 •
edited
Loading

@emteknetnz emteknetnz mentioned this pull request Feb 26, 2025
Closed
3 tasks
@emteknetnz emteknetnz force-pushed the pulls/3.0/react-table branch 8 times, most recently from aecd949 to 6c0e03e Compare March 3, 2025 22:46
@GuySartorelli
Copy link
Member

Seems to work as expected but will hold off merging until this isn't in draft

@emteknetnz emteknetnz marked this pull request as ready for review March 4, 2025 23:13
@emteknetnz emteknetnz force-pushed the pulls/3.0/react-table branch from 6c0e03e to a66275a Compare March 5, 2025 00:08
emteknetnz
emteknetnz commented Mar 5, 2025
View reviewed changes
tests/behat/features/table-view.feature
@assets
Scenario: I can switch the gallery between table and thumbnail mode
When I click on the file named "folder1" in the gallery
And I press the "table" button
And I wait until I see the ".gallery__table-row" element
Then I should see a ".gallery__main-view--table" element
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a griddle class that wrapped the table. We're already asserting that we see a .gallery__table-row and a .gallery__table-column--image so we don't need to assert anything else.

@emteknetnz emteknetnz force-pushed the pulls/3.0/react-table branch from a66275a to 2312858 Compare March 5, 2025 00:10
GuySartorelli
GuySartorelli approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit a2c83d2 into silverstripe:3.0 Mar 5, 2025
8 of 15 checks passed
@GuySartorelli GuySartorelli deleted the pulls/3.0/react-table branch March 5, 2025 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli