Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate off griddle JS dep #1892

Closed
3 tasks done
emteknetnz opened this issue Jan 20, 2025 · 2 comments
Closed
3 tasks done

Migrate off griddle JS dep #1892

emteknetnz opened this issue Jan 20, 2025 · 2 comments

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Jan 20, 2025

Follow on from silverstripe/.github#336 (comment)

Griddle is an old abandoned JS dep that's used in in asset-admin TableView.js, ThumbnailView.js, and versioned-admin HistoryViewer.js

It should be replaced with something else, preferably the same library that's used to eventually replace the entwine gridfield with a react gridfield, though possibly we shouldn't worry about this.

Acceptance criteria

  • Components that use griddle use a differently library
  • Functionality remains roughly the same
  • Griddle dependency is removed

Kitchen sink CI

PRs

@GuySartorelli
Copy link
Member

Webpack-config merged - reassigning to Steve to tag a release for it in npm and update PRs to use the latest version of it.

@GuySartorelli
Copy link
Member

PRs merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants