Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort properly Go imports #4071

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Conversation

dmitris
Copy link
Contributor

@dmitris dmitris commented Feb 18, 2025

Summary

As in the previously merged #4061 and #4062, sort the Go imports to be in the alphabetical order (mostly the "third-party" = non-stdlib imports though pkg/cosign/errors_test.go had the stdlib imports in a wrong order).
As mentioned in #4062,

I propose to keep all the third-party (non-stdlib) imports in just one block to make it easier for the IDEs to properly sort those imports on addition or deletion.

I didn't change the existing extra blank lines where they don't violate the alphabetical sorted order of the imports.

Release Note

NONE

Documentation

n/a

@dmitris dmitris requested a review from a team as a code owner February 18, 2025 13:38
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.76%. Comparing base (2ef6022) to head (63ec684).
Report is 315 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4071      +/-   ##
==========================================
- Coverage   40.10%   36.76%   -3.35%     
==========================================
  Files         155      210      +55     
  Lines       10044    13386    +3342     
==========================================
+ Hits         4028     4921     +893     
- Misses       5530     7847    +2317     
- Partials      486      618     +132     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Dmitry Savintsev <dsavints@gmail.com>
@haydentherapper haydentherapper merged commit a0b20b7 into sigstore:main Feb 19, 2025
29 checks passed
@dmitris dmitris deleted the go-imports-sort branch February 20, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants