Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix comment typo and imports order #4061

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Conversation

dmitris
Copy link
Contributor

@dmitris dmitris commented Feb 17, 2025

Summary

Fix a tiny typo in the function comment and the imports order - the stdlib packages should go first.

Release Note

NONE

Documentation

n/a

@dmitris dmitris requested a review from a team as a code owner February 17, 2025 10:48
@dmitris dmitris force-pushed the comment-typo branch 3 times, most recently from 1a64421 to cd25f5c Compare February 17, 2025 10:52
Signed-off-by: Dmitry Savintsev <dsavints@gmail.com>
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.76%. Comparing base (2ef6022) to head (b9c2270).
Report is 310 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4061      +/-   ##
==========================================
- Coverage   40.10%   36.76%   -3.35%     
==========================================
  Files         155      210      +55     
  Lines       10044    13386    +3342     
==========================================
+ Hits         4028     4921     +893     
- Misses       5530     7847    +2317     
- Partials      486      618     +132     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hectorj2f hectorj2f merged commit 736acbd into sigstore:main Feb 17, 2025
29 checks passed
@dmitris dmitris deleted the comment-typo branch February 17, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants