Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set scaffolding version instead of main #2437

Closed
wants to merge 1 commit into from

Conversation

hectorj2f
Copy link
Contributor

Signed-off-by: Hector Fernandez hector@chainguard.dev

Summary

CI tests are failing due to changes in Fulcio that affect the current Scaffolding main branch:
Screenshot 2022-11-10 at 13 37 56

We got Fulcio changes from its main branch expecting to spin up a grpc server. Therefore, we should set scaffolding to a stable version instead of main (temporary)

Release Note

Documentation

@hectorj2f hectorj2f self-assigned this Nov 10, 2022
@hectorj2f hectorj2f requested review from cpanato and vaikas November 10, 2022 12:40
@hectorj2f hectorj2f added the bug Something isn't working label Nov 10, 2022
dlorenc
dlorenc previously approved these changes Nov 10, 2022
@cpanato
Copy link
Member

cpanato commented Nov 10, 2022

there are two required tests that i did not find in the workdlows, but there is a open PR for that https://github.com/sigstore/cosign/pull/2299/files

Signed-off-by: Hector Fernandez <hector@chainguard.dev>
@hectorj2f
Copy link
Contributor Author

It is working now https://github.com/sigstore/cosign/actions/runs/3437409368/jobs/5732124572#step:8:179. Closing this PR! It was fixed here: #2299

@hectorj2f hectorj2f closed this Nov 10, 2022
@hectorj2f hectorj2f deleted the set_scaffolding_version branch November 10, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants