Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update version comments and general cleanup #2436

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Nov 10, 2022

Summary

  • update version comments and general cleanup

now dependabot can update the version comments but for that the comment should be up-to-date :)
this pr updates missing bumps and the version comments for the actions.
also some general cleanup

hectorj2f
hectorj2f previously approved these changes Nov 10, 2022
@hectorj2f
Copy link
Contributor

It seems there is an error in our CI. Error from server (NotFound): services.serving.knative.dev "fulcio-grpc" not found
I also experienced it in my PR.

dlorenc
dlorenc previously approved these changes Nov 10, 2022
@hectorj2f
Copy link
Contributor

I expect this PR #2437 to fix the current CI issue.

@cpanato cpanato dismissed stale reviews from dlorenc and hectorj2f via cfd98ac November 10, 2022 15:02
@cpanato cpanato requested a review from hectorj2f November 10, 2022 15:03
@codecov-commenter
Copy link

Codecov Report

Merging #2436 (cfd98ac) into main (1fd8c9c) will decrease coverage by 0.60%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2436      +/-   ##
==========================================
- Coverage   30.48%   29.87%   -0.61%     
==========================================
  Files         136      136              
  Lines        8384     8384              
==========================================
- Hits         2556     2505      -51     
- Misses       5494     5564      +70     
+ Partials      334      315      -19     
Impacted Files Coverage Δ
pkg/oci/layout/signatures.go 0.00% <0.00%> (-53.85%) ⬇️
pkg/oci/layout/write.go 0.00% <0.00%> (-37.50%) ⬇️
pkg/oci/layout/index.go 0.00% <0.00%> (-28.58%) ⬇️
pkg/blob/load.go 67.50% <0.00%> (-5.00%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: cpanato <ctadeu@gmail.com>
Copy link
Contributor

@hectorj2f hectorj2f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@cpanato cpanato enabled auto-merge (squash) November 10, 2022 15:40
@cpanato cpanato merged commit d067d40 into sigstore:main Nov 10, 2022
@cpanato cpanato deleted the cleanup-actions branch November 10, 2022 15:54
@github-actions github-actions bot added this to the v1.14.0 milestone Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants