Skip to content
This repository has been archived by the owner on Oct 23, 2024. It is now read-only.

Make cpu monitor default instead of collectd/cpu #1147

Merged
merged 1 commit into from
Jan 21, 2020
Merged

Make cpu monitor default instead of collectd/cpu #1147

merged 1 commit into from
Jan 21, 2020

Conversation

keitwb
Copy link
Contributor

@keitwb keitwb commented Jan 17, 2020

  • Also remove collectd/cpufreq from standard configs
  • Replace collectd/cpu with cpu in some of the integration tests

@keitwb keitwb requested a review from asuresh4 as a code owner January 17, 2020 14:09
@keitwb keitwb requested a review from a user January 17, 2020 14:09
@keitwb keitwb force-pushed the cpu-default branch 2 times, most recently from 8d74545 to adf8ee8 Compare January 17, 2020 14:14
mstumpfx
mstumpfx approved these changes Jan 21, 2020
View reviewed changes
pkg/monitors/collectd/cpu/metadata.yaml Outdated
@@ -1,6 +1,10 @@
monitors:
- dimensions:
doc: |
**This monitor is deprecated in favor of the `cpu` monitor. Please switch
to that monitor, as this monitor will be remove in a future agent
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
to that monitor, as this monitor will be remove in a future agent
to that monitor, as this monitor will be removed in a future agent

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be useful to just put "removed in 5.0" instead of future

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be useful to just put "removed in 5.0" instead of future

It isn't being removed in 5.0, it is just not part of the default config. It will be totally removed in some later major release.

Make cpu monitor default instead of collectd/cpu
88d2823 
 - Also remove collectd/cpufreq from standard configs
 - Replace collectd/cpu with cpu in some of the integration tests
 - Add deprecation notice to collectd/cpu monitor
@keitwb keitwb merged commit 91fabc5 into 5.0-staging Jan 21, 2020
@keitwb keitwb deleted the cpu-default branch January 21, 2020 19:02
keitwb pushed a commit that referenced this pull request Jan 21, 2020
@benkeith-splunk
Make cpu monitor default instead of collectd/cpu (#1147)
1b08146 
- Also remove collectd/cpufreq from standard configs
 - Replace collectd/cpu with cpu in some of the integration tests
 - Add deprecation notice to collectd/cpu monitor
keitwb pushed a commit that referenced this pull request Jan 22, 2020
@benkeith-splunk
Make cpu monitor default instead of collectd/cpu (#1147)
6c44477 
- Also remove collectd/cpufreq from standard configs
 - Replace collectd/cpu with cpu in some of the integration tests
 - Add deprecation notice to collectd/cpu monitor
keitwb pushed a commit that referenced this pull request Jan 22, 2020
@benkeith-splunk
Make cpu monitor default instead of collectd/cpu (#1147)
e5ffd19 
- Also remove collectd/cpufreq from standard configs
 - Replace collectd/cpu with cpu in some of the integration tests
 - Add deprecation notice to collectd/cpu monitor
keitwb pushed a commit that referenced this pull request Jan 28, 2020
@benkeith-splunk
Make cpu monitor default instead of collectd/cpu (#1147)
234d3f6 
- Also remove collectd/cpufreq from standard configs
 - Replace collectd/cpu with cpu in some of the integration tests
 - Add deprecation notice to collectd/cpu monitor
keitwb pushed a commit that referenced this pull request Jan 29, 2020
@benkeith-splunk
Make cpu monitor default instead of collectd/cpu (#1147)
ce656ee 
- Also remove collectd/cpufreq from standard configs
 - Replace collectd/cpu with cpu in some of the integration tests
 - Add deprecation notice to collectd/cpu monitor
keitwb pushed a commit that referenced this pull request Jan 30, 2020
@benkeith-splunk
Make cpu monitor default instead of collectd/cpu (#1147)
41b3747 
- Also remove collectd/cpufreq from standard configs
 - Replace collectd/cpu with cpu in some of the integration tests
 - Add deprecation notice to collectd/cpu monitor
keitwb pushed a commit that referenced this pull request Feb 21, 2020
@benkeith-splunk
Make cpu monitor default instead of collectd/cpu (#1147)
8c2d851 
- Also remove collectd/cpufreq from standard configs
 - Replace collectd/cpu with cpu in some of the integration tests
 - Add deprecation notice to collectd/cpu monitor
keitwb pushed a commit that referenced this pull request Feb 24, 2020
@benkeith-splunk
Make cpu monitor default instead of collectd/cpu (#1147)
fce803c 
- Also remove collectd/cpufreq from standard configs
 - Replace collectd/cpu with cpu in some of the integration tests
 - Add deprecation notice to collectd/cpu monitor
keitwb pushed a commit that referenced this pull request Feb 25, 2020
@benkeith-splunk
Make cpu monitor default instead of collectd/cpu (#1147)
e7b2cbf 
- Also remove collectd/cpufreq from standard configs
 - Replace collectd/cpu with cpu in some of the integration tests
 - Add deprecation notice to collectd/cpu monitor
keitwb pushed a commit that referenced this pull request Feb 25, 2020
@benkeith-splunk
Make cpu monitor default instead of collectd/cpu (#1147)
5ca25ab 
- Also remove collectd/cpufreq from standard configs
 - Replace collectd/cpu with cpu in some of the integration tests
 - Add deprecation notice to collectd/cpu monitor
keitwb pushed a commit that referenced this pull request Feb 28, 2020
@benkeith-splunk @keitwb
Make cpu monitor default instead of collectd/cpu (#1147)
b84b44a 
- Also remove collectd/cpufreq from standard configs
 - Replace collectd/cpu with cpu in some of the integration tests
 - Add deprecation notice to collectd/cpu monitor
@atoulme atoulme mentioned this pull request Dec 8, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mstumpfx mstumpfx mstumpfx approved these changes

@asuresh4 asuresh4 Awaiting requested review from asuresh4

@jchengsfx jchengsfx Awaiting requested review from jchengsfx

@molner molner Awaiting requested review from molner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keitwb @mstumpfx