fix(shorebird_cli): handle exceptions during validation more gracefully #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eseidel
approved these changes
Apr 24, 2023
| @@ -15,7 +15,7 @@ class _MockPlatform extends Mock implements Platform {} | |||
| class _MockShorebirdProcess extends Mock implements ShorebirdProcess {} | |||
|
|
|||
| void main() { | |||
| group('ShorebirdFlutterValidator', () { | |||
| group(ShorebirdFlutterValidator, () { | |||
There was a problem hiding this comment.
You can pass a class name to group? til.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The ShorebirdFlutterValidator could previously throw unhandled exceptions if it failed to successfully execute
flutter --version. This change catches those exceptions and treats them as validation errors.This change also renames
flutter_validation_mixin.darttoshorebird_validation_mixin.dartto reflect the class contained in the file.Fixes #357.
Type of Change