Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bad output from validation failure? #357

Closed
eseidel opened this issue Apr 24, 2023 · 2 comments · Fixed by #359
Closed

fix: bad output from validation failure? #357

eseidel opened this issue Apr 24, 2023 · 2 comments · Fixed by #359
Assignees
Labels
bug Something isn't working

Comments

@eseidel
Copy link
Contributor

eseidel commented Apr 24, 2023

Unhandled exception:
Instance of 'FlutterValidationException'
#0      ShorebirdFlutterValidator._getFlutterVersion (package:shorebird_cli/src/validators/shorebird_flutter_validator.dart:139:7)
<asynchronous suspension>
#1      ShorebirdFlutterValidator.validate (package:shorebird_cli/src/validators/shorebird_flutter_validator.dart:58:37)
<asynchronous suspension>
#2      Future.wait.<anonymous closure> (dart:async/future.dart:522:21)
<asynchronous suspension>
#3      ShorebirdValidationMixin.logValidationIssues (package:shorebird_cli/src/flutter_validation_mixin.dart:8:31)
<asynchronous suspension>
#4      RunCommand.run (package:shorebird_cli/src/commands/run_command.dart:36:5)
<asynchronous suspension>
#5      CommandRunner.runCommand (package:args/command_runner.dart:212:13)
<asynchronous suspension>
#6      ShorebirdCliCommandRunner.runCommand (package:shorebird_cli/src/command_runner.dart:131:18)
<asynchronous suspension>
#7      ShorebirdCliCommandRunner.run (package:shorebird_cli/src/command_runner.dart:92:14)
<asynchronous suspension>
#8      main (file:///Users/eseidel/Documents/GitHub/_shorebird/shorebird/packages/shorebird_cli/bin/shorebird.dart:6:24)
<asynchronous suspension>

I suspect my command line arg is wrong, but it could fail better I think?

@eseidel eseidel added the bug Something isn't working label Apr 24, 2023
@felangel
Copy link
Contributor

I think this might be a duplicate of #337

@eseidel
Copy link
Contributor Author

eseidel commented Apr 24, 2023

Yeah, there are two places which throw a FlutterValidationException, but no places which catch one. Presumably the mixin is supposed to do that? @bryanoltman said he could take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants