Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: detect native changes in Windows patches #2758

Merged
merged 8 commits into from
Jan 14, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Reenable native diff checking
  • Loading branch information
bryanoltman committed Jan 14, 2025
commit 82b446b7b04c3d7925eb5d20a27591b4a0e8a2ea
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,8 @@ class WindowsArchiveDiffer extends ArchiveDiffer {

@override
bool isNativeFilePath(String filePath) {
// TODO(bryanoltman): reenable this check once we can reliably report
// native diffs
// const nativeFileExtensions = ['.dll', '.exe'];
// return nativeFileExtensions.contains(p.extension(filePath));
return false;
const nativeFileExtensions = ['.dll', '.exe'];
return nativeFileExtensions.contains(p.extension(filePath));
}

@override
Expand Down
Loading